Open
Conversation
# Make SafetyWindow a Parameter ## What problem does this solve? During a recent chain halt, we skipped making SafetyWindow a parameter to reduce risk and expedite recovery. We fixed it at 50. The problem: - Most urgently, this broke our integration tests, because there was no way to override the value, breaking all CPoC Integration tests because Epochs are shorter than 50 blocks for testing, meaning no CPoC ever executes - Secondarily, but also important, this puts an important value impacting chain execution under proper governance control. ## How do you know this is a real problem? Currently there are at least 4 failing integration tests, obscuring our ability to verify other code problems. ## How does this solve the problem? - Add a new parameter to EpochParameters for SafetyWindow (default to 50, per the current value) - Remove the hard coded value - Fix tests to override this to 0 ## What risks does this introduce? How can we mitigate those risks? - There is very little risk, but an upgrade issue would be caught via testnet update testing, done for every upgrade. ## How do you know this PR fixes the problem? Integration Tests now pass when they failed.
Add broker command to set node failure reason Trigger auto-tests after node registration in admin Trigger auto-tests on version status endpoint Add manual MLnode testing endpoint in admin
Track participant weight changes for status updates
dont need to do auto test for upgrade
minor modify for common func
83b0682 to
43677e2
Compare
90d1c23 to
8b29a8e
Compare
7babccb to
8a0c4bd
Compare
8a0c4bd to
a5c7e3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.