Skip to content

Jf/onboarding clarity enhancement clean#1

Open
jacky6block wants to merge 33 commits intomainfrom
jf/onboarding_clarity_enhancement_clean
Open

Jf/onboarding clarity enhancement clean#1
jacky6block wants to merge 33 commits intomainfrom
jf/onboarding_clarity_enhancement_clean

Conversation

@jacky6block
Copy link
Owner

No description provided.

patimen and others added 26 commits February 27, 2026 09:41
# Make SafetyWindow a Parameter
## What problem does this solve?
During a recent chain halt, we skipped making SafetyWindow a parameter to reduce risk and expedite recovery. We fixed it at 50. The problem: 
- Most urgently, this broke our integration tests, because there was no way to override the value, breaking all CPoC Integration tests because Epochs are shorter than 50 blocks for testing, meaning no CPoC ever executes
- Secondarily, but also important, this puts an important value impacting chain execution under proper governance control.

## How do you know this is a real problem?
Currently there are at least 4 failing integration tests, obscuring our ability to verify other code problems.

## How does this solve the problem?
- Add a new parameter to EpochParameters for SafetyWindow (default to 50, per the current value)
- Remove the hard coded value
- Fix tests to override this to 0

## What risks does this introduce? How can we mitigate those risks?
- There is very little risk, but an upgrade issue would be caught via testnet update testing, done for every upgrade.

## How do you know this PR fixes the problem?
Integration Tests now pass when they failed.
Add broker command to set node failure reason
Trigger auto-tests after node registration in admin
Trigger auto-tests on version status endpoint
Add manual MLnode testing endpoint in admin
Track participant weight changes for status updates
dont need to do auto test for upgrade
@Ryanchen911 Ryanchen911 force-pushed the jf/onboarding_clarity_enhancement_clean branch from 83b0682 to 43677e2 Compare February 28, 2026 08:31
@Ryanchen911 Ryanchen911 force-pushed the jf/onboarding_clarity_enhancement_clean branch 2 times, most recently from 90d1c23 to 8b29a8e Compare March 2, 2026 05:40
@Ryanchen911 Ryanchen911 force-pushed the jf/onboarding_clarity_enhancement_clean branch 2 times, most recently from 7babccb to 8a0c4bd Compare March 2, 2026 08:52
@Ryanchen911 Ryanchen911 force-pushed the jf/onboarding_clarity_enhancement_clean branch from 8a0c4bd to a5c7e3d Compare March 3, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants